lib: allow long paths for require on Windows

[targos]

#1801 introduced internal fs methods to speed up require.
The methods do not call path._makeLong like their counterpart
from the fs module. This brings back the old behaviour.

Fixes: #1990
Fixes: #1980

[targos]

I could not test it yet as I am not on a Windows machine right now.
I'll also add a test.

[vkurchatkin]

LGTM, but it needs a test

[ChALkeR]

Maybe it would be better to wrap internalModuleStat and internalModuleReadFile?
Just asking.

[targos]

test added. I copied the filename generation from https://github.com/nodejs/io.js/blob/master/test/parallel/test-fs-long-path.js#L9-L12
The result is a path length of exactly 260 characters. Shouldn't it be at least 261 ?
If I read this correctly, 260 is still allowed.

[mscdex]

The commit should target the module subsystem instead of lib.

[ChALkeR]

@targoshttps://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#maxpath states that those are 260 chars including the terminating NULL, so max safe path length is 259 significant chars (including the drive letter).

For example, the maximum path on drive D is "D:\some 256-character path string" where "" represents the invisible terminating null character for the current system codepage. (The characters < > are used here for visual clarity and cannot be part of a valid path string.)

But I guess it would do no harm to make the test path a big longer.

[piscisaureus]

The test should clean up after itself and delete the temp file.
Other than that, LGTM.

[othiym23]

Given that #1849, #1980, and #1990 affect npm (see npm/npm#8419 for details) on newer versions of io.js, I'm a strong +1 on getting this landed.

[targos]

@ChALkeR I am now on my Windows machine and can confirm it fails with 260 chars so I'm leaving it like that.
@mscdex@piscisaureus followed your suggestions

[targos]

I still can't confirm the fix is actually working (installing VS right now) so a CI could be useful

[piscisaureus]

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/23/

[piscisaureus]

@nodejs/build the win2008r2 build slave seems to be stuck on a failed git clean -fdx.

[piscisaureus]

Tested locally and landed (with a minor modification to the test) in 671e64a.
@targos Thanks for your patch.