win, tools: add nasm to boxstarter script#19950
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds NASM installation to the Boxstarter script. Refs: nodejs#19918
ContributorAuthor
bzoz commented Apr 11, 2018
bnoordhuis approved these changes Apr 11, 2018
vsemozhetbyt added windows 
BridgeAR approved these changes Apr 11, 2018
BridgeAR added fast-track 
jasnell approved these changes Apr 14, 2018
jasnell pushed a commit that referenced this pull request Apr 14, 2018
Adds NASM installation to the Boxstarter script. Refs: #19918 PR-URL: #19950 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 14, 2018
Landed in 887f4c5 |
jasnell pushed a commit that referenced this pull request Apr 16, 2018
Adds NASM installation to the Boxstarter script. Refs: #19918 PR-URL: #19950 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Adds NASM installation to the Boxstarter script. Refs: nodejs#19918 PR-URL: nodejs#19950 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
Adds NASM installation to the Boxstarter script. Refs: #19918 PR-URL: #19950 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NASM installation to the Boxstarter script.
Refs: #19918
Checklist