vm: remove unnecessary HandleScopes#2001
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The accessors run inside an implicit HandleScope, there is no need to create a new one. PR-URL: nodejs#2001 Reviewed-By: Trevor Norris <[email protected]>
Contributor
trevnorris commented Jun 17, 2015
LGTM |
bnoordhuisforce-pushed the remove-handlescopes branch from 0e6410f to 5d0cee4Compare
Contributor
domenic commented Jun 17, 2015
For my future learnings, how do you know this? |
Member
rvagg commented Jun 17, 2015
my understanding is that methods that are called by V8 from JS code have an implicit |
MemberAuthor
bnoordhuis commented Jun 17, 2015
@domenic It's part of the generated code: https://github.com/nodejs/io.js/blob/v2.3.0/deps/v8/src/x64/code-stubs-x64.cc#L4751-4761 ( |
Contributor
domenic commented Jun 17, 2015
Awesome, thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accessors run inside an implicit HandleScope, there is no need to
create a new one.
R=@trevnorris?
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/37/