doc: added explicitly that the close event does not take arguments#20031
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018
nodejs-github-bot added doc 
ryzokuken approved these changes Apr 14, 2018
Contributor
ryzokuken commented Apr 14, 2018
cc @mcollina @nodejs/http2 |
doc/api/http2.md Outdated
| --> | ||
| The `'close'` event is emitted once the `Http2Session` has been destroyed. | ||
| The `'close'` event is emitted once the `Http2Session` has been destroyed. It |
Contributor
There was a problem hiding this comment.
Thank you!
Feel free to ignore, but maybe it would be a bit more clear if we write "Its listener does not expect any arguments"?
ContributorAuthor
There was a problem hiding this comment.
Thanks! Good idea. I edited the wording to reflect the change.
Added wording to better state that it is in fact the listener that is not expecting any arguments Fixes: nodejs#20018
vsemozhetbyt approved these changes Apr 14, 2018
vsemozhetbyt added the fast-track 
Contributor
vsemozhetbyt commented Apr 14, 2018
vsemozhetbyt added the author ready 
trivikr approved these changes Apr 14, 2018
jasnell approved these changes Apr 14, 2018
Contributor
Because this was |
trivikr pushed a commit that referenced this pull request Apr 14, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: #20018 PR-URL: #20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell pushed a commit that referenced this pull request Apr 16, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: #20018 PR-URL: #20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018 PR-URL: nodejs#20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018 PR-URL: nodejs#20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 11, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018 PR-URL: nodejs#20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 19, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018 PR-URL: nodejs#20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: nodejs#20018 PR-URL: nodejs#20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
Explicitly added in the docs that the close event does not expect any arguments when invoked. Fixes: #20018 Backport-PR-URL: #22850 PR-URL: #20031 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jun 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly added in the docs that the close event does not expect
any arguments when invoked.
Fixes: #20018
Checklist