test: assert tmp and fixture dirs different#2015
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added fs 
MemberAuthor
Trott commented Jun 22, 2015
Anyone feel like weighing in with a "LGTM" or a "OMGWTFBBQNO!!!"? Or a "SHRUG"? /ping @nodejs/collaborators |
Contributor
trevnorris commented Jun 22, 2015
Oh good crap. That comment is from 2010. LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Jun 22, 2015
PR-URL: nodejs#2015 Reviewed-By: Trevor Norris <[email protected]>
MemberAuthor
Trott commented Jun 22, 2015
Merged in 5d2b846 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect the
todocomment eliminated here is obsolete and/or overkill, butassert()put in place just in case...CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/56/