Skip to content

http2: reduce require calls in http2/core#20422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danbev wants to merge 1 commit into from
Closed

http2: reduce require calls in http2/core #20422

danbev wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbevdanbev commented Apr 30, 2018

This commit removes unnecesary requires of http and internal/util in
http2/core.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
http2: reduce require calls in http2/core
c929963
This commit removes unnecesary requires of http and internal/util in http2/core.js
@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Apr 30, 2018
@danbev
Copy link
ContributorAuthor

danbev commented Apr 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14596/

@BridgeAR
Copy link
Member

BridgeAR commented Apr 30, 2018

-0 as this is mainly churn out of my perspective.

@danbev
Copy link
ContributorAuthor

danbev commented May 2, 2018

Landed in 557f570.

@danbevdanbev closed this May 2, 2018
@danbevdanbev deleted the http2_core_requires branch May 2, 2018 06:46
danbev added a commit to danbev/node that referenced this pull request May 2, 2018
@danbev
http2: reduce require calls in http2/core
557f570
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@danbev@MylesBorins
http2: reduce require calls in http2/core
42bbaa3
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: #20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@danbev@kjin
http2: reduce require calls in http2/core
27a337a
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 11, 2018
@danbev@kjin
http2: reduce require calls in http2/core
1f55a39
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 19, 2018
@danbev@kjin
http2: reduce require calls in http2/core
1b7d030
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@danbev@kjin
http2: reduce require calls in http2/core
d9efc87
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@danbev@BethGriggs
http2: reduce require calls in http2/core
74192dd
This commit removes unnecesary requires of http and internal/util in http2/core.js Backport-PR-URL: #22850 PR-URL: #20422 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@trivikrtrivikrtrivikr approved these changes

+2 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danbev@BridgeAR@apapirovski@lpinca@TimothyGu@trivikr@nodejs-github-bot