Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
configure: remove compiler detection#205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
The GCC version is no longer relevant since only 4.8 and newer are supported. It's probably safe to assume clang on mac since V8 does so too.
The GCC version is no longer relevant since only 4.8 and newer are supported. It's probably safe to assume clang on mac since V8 does so too. PR-URL: #205 Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis commented Dec 23, 2014
Cheers Nikolai, landed in 0f3d7e6. |
saper commented Mar 9, 2015
I am working on getting sass/node-sass to build on FreeBSD and I'd like to use I think this commit disabled |
jbergstroem commented Mar 9, 2015
@saper I'm agree with @mgreter about binary releases not always being the best solution. A compiler check wouldn't necessary solve your problem since clang just as well can compile against |
saper commented Mar 9, 2015
No problem, I will use it for |
V8 has changed how Function.blah entries look like in stack traces (see https://crrev.com/c/5907815). This CL updates tests expectations according to new behavior and re-enables the affected tests.
The GCC version is no longer relevant since only 4.8 and newer are supported. It's probably safe to assume clang on mac since V8 does so too.