Skip to content

Conversation

@addaleax
Copy link
Member

Always easy enough to re-introduce if we do need it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Always easy enough to re-introduce if we do need it.
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 5, 2018
@addaleaxaddaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 5, 2018
@addaleax
Copy link
MemberAuthor

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2018
@addaleax
Copy link
MemberAuthor

Landed in 5bb5d61

@addaleaxaddaleax closed this May 9, 2018
@addaleaxaddaleax deleted the no-freelist branch May 9, 2018 16:28
addaleax added a commit that referenced this pull request May 9, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
targos pushed a commit that referenced this pull request May 12, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@addaleaxaddaleax mentioned this pull request May 14, 2018
addaleax added a commit that referenced this pull request Jun 29, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@bnoordhuis@danbev@jasnell@TimothyGu@cjihrig@mmarchini@nodejs-github-bot