Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
module: force require('process') to return a reference to process#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
vkurchatkin commented Dec 23, 2014
Why not |
lxe commented Dec 23, 2014
@vkurchatkin there were a few ways to do this... making |
bnoordhuis commented Dec 23, 2014
I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js. |
lxe commented Dec 23, 2014
@bnoordhuis added |
lib/process.js Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to either // Copyright io.js contributors or your own / your company's name?
bnoordhuis commented Dec 24, 2014
LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that. |
lxe commented Dec 25, 2014
Happy holidays everyone! |
bnoordhuis commented Dec 30, 2014
@lxe Still one nit but if you fix that, I'll land it. Thanks. |
This makes require('process') always return a reference to the global process object.lxe commented Dec 30, 2014
@bnoordhuis totally missed that one! Thanks. |
This makes require('process') always return a reference to the global process object. PR-URL: #206 Reviewed-By: Ben Noordhuis <[email protected]>bnoordhuis commented Dec 30, 2014
Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks! |
lxe commented Dec 30, 2014
Great stuff @bnoordhuis. thank you! |
rvagg commented Jan 2, 2015
ftr, agreed to merge this in TC meeting 2014-12-30 #229 |
This makes require('process') always return a reference to the global process object. Fixes#157