deps: cherry-pick aa6ce3e from upstream V8

[mmarchini]

Original commit message:

[log][api] introduce public CodeEventListener API Introduce a new public API called CodeEventListener to allow embedders to better support external profilers and other diagnostic tools without relying on unsupported methods like --perf-basic-prof. Bug: v8:7694 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I063cc965394d59401358757634c9ea84c11517e9 Co-authored-by: Daniel Beckert <[email protected]> Reviewed-on: chromium-review.googlesource.com/1028770 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Hannes Payer <[email protected]> Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/master@{#53382} 

Refs: v8/v8@aa6ce3e

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[mmarchini]

CI: https://ci.nodejs.org/job/node-test-pull-request/15251/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1401/

[mmarchini]

cc @nodejs/diagnostics

[targos]

The fixup isn't upstream?

[mmarchini]

The fixup isn't upstream?

The patch didn't build because the Address typedef is different between V8 6.7 and V8 6.8 (see https://chromium-review.googlesource.com/c/v8/v8/+/988657). I can try to float https://chromium-review.googlesource.com/c/v8/v8/+/988657 as well instead of changing the Patch to work on V8 6.7.

[targos]

I can try to float chromium-review.googlesource.com/c/v8/v8/+/988657 as well instead of changing the Patch to work on V8 6.7.

It's a big patch. I prefer we stick with your fix.

[mmarchini]

Floating https://chromium-review.googlesource.com/c/v8/v8/+/988657 is non-trivial :(

Error: Command failed: git apply -3 --directory=deps/v8 error: patch failed: deps/v8/src/compiler/wasm-compiler.cc:2619 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/src/compiler/wasm-compiler.cc: patch does not apply error: patch failed: deps/v8/src/log.cc:309 Falling back to three-way merge... Applied patch to 'deps/v8/src/log.cc' cleanly. error: patch failed: deps/v8/src/profiler/profile-generator.h:47 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/src/profiler/profile-generator.h: patch does not apply error: patch failed: deps/v8/src/profiler/profiler-listener.h:59 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/src/profiler/profiler-listener.h: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-arm.cc:53 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-arm.cc: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-arm64.cc:54 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-arm64.cc: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-ia32.cc:54 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-ia32.cc: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-mips.cc:55 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-mips.cc: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-mips64.cc:55 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-mips64.cc: patch does not apply error: patch failed: deps/v8/test/cctest/test-code-stubs-x64.cc:54 error: repository lacks the necessary blob to fall back on 3-way merge. error: deps/v8/test/cctest/test-code-stubs-x64.cc: patch does not apply 

For context: this API will allow users to generate the map file required by Linux perf during runtime. Today the file is generated by --perf-basic-prof, which will keep writing to the file during the entire application lifetime, leading to file growth problems. Sice V8 6.7 fixed Linux perf for Interpreted Functions, it would be really nice to also have this API when V8 6.7 lands on Node.js v10.x.

[hashseed]

Yeah let's not float the Address patch.

[mmarchini]

CI: https://ci.nodejs.org/job/node-test-pull-request/15393/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1415/
V8 CI rerun: https://ci.nodejs.org/job/node-test-commit-v8-linux/1416/

[mmarchini]

Cherry-picking one more commit here (v8/v8@b20faff) to fix a bug when using this API with --interpreted-frames-native-stack on. If there are no objections I'd like to land this tomorrow.

/cc @nodejs/diagnostics @nodejs/v8-update

[targos]

There is an issue with the v8 ci. Can you try to run it again?

[mmarchini]

V8 CI rerun: https://ci.nodejs.org/job/node-test-commit-v8-linux/1416/

[mhdawson]

LGTM

[mmarchini]

Blocking due to another bug found in the API.

Waiting for upstream fix to land: https://chromium-review.googlesource.com/c/v8/v8/+/1097578

[mmarchini]

CI: https://ci.nodejs.org/job/node-test-pull-request/15514/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1441/

[mmarchini]

@targos should I squash the fixup when landing, or sould I keep it as a separate commit?

[targos]

Squash please and write "backport" instead of cherry-pick in the commit message

[mmarchini]

CI: https://ci.nodejs.org/job/node-test-pull-request/15557/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1474/