test: add missing crypto checks#2129
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a check for crypto before using it, similar to how other tests work.
Contributor
shigeki commented Jul 8, 2015
I wrote these tests and missed to add the checks. Thanks for catching. LGTM. |
Contributor
Fishrock123 commented Jul 8, 2015
LGTM |
jbergstroem added a commit that referenced this pull request Jul 8, 2015
Add a check for crypto before using it, similar to how other tests work. PR-URL: #2129 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MemberAuthor
jbergstroem commented Jul 8, 2015
Merged in 2ba1740. Thanks for the review. |
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Add a check for crypto before using it, similar to how other tests work. PR-URL: nodejs#2129 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for crypto before using it, similar to how other tests work.
Guess my previous commit ("Refactor all tests that depends on crypto", 671fbd5) wasn't accurate 🐼
/R=@shigeki? (you reviewed last time)