http2: pass incoming set-cookie header as array#21360
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ryzokuken commented Jun 16, 2018
/cc @nodejs/http2 |
ryzokuken commented Jun 16, 2018
@maclover7 @nodejs/github-bot any idea why neither the CI nor labelling script in the bot was triggered for this one? It seems rather strange. |
joyeecheung commented Jun 16, 2018
@ryzokuken The bot is down now: nodejs/build#1353 |
BridgeAR commented Jun 18, 2018
@nodejs/http2 PTAL |
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
LGTM but I would prefer if we could just tack this test on to one of the existing headers tests rather than creating a new one for such a small behaviour.
@apapirovski ok, will try to move the test. I have chosen the easiest way to reproduce this 😁 |
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
LGTM with a small nit.
There was a problem hiding this comment.
Could you add a dot at the end of this sentence, please?
There was a problem hiding this comment.
Sure, will do that soon. As #21296 landed I have to update doc for set-cookie also.
apapirovski commented Jun 25, 2018
apapirovski added the author ready apapirovski commented Jun 25, 2018
Weird failures last time. CI: https://ci.nodejs.org/job/node-test-pull-request/15606/ |
@apapirovski Looks like CI got confused because I did a git rebase. It tries to checkout commit Applies at least to some of the CI jobs. |
apapirovski commented Jun 26, 2018
Was there a merge commit by any chance? Weird that this is happening. Could you maybe squash? |
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code.
Flarna commented Jun 26, 2018
No, it was a "normal" rebase. Rebased again and squashed. |
Flarna commented Jul 3, 2018
Is there anything I should add here? |
mcollina commented Jul 5, 2018
mcollina commented Jul 5, 2018
Landed in d4966a1 |
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. PR-URL: nodejs#21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Incoming set-cookie headers should be passed to user as array like in http module. Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code. Backport-PR-URL: #22850 PR-URL: #21360 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
9 participants
Incoming set-cookie headers should be passed to user as array like in http module - even for single occurrence.
Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRegarding doc: If this PR is accepted #21296 should be updated accordingly - or doc needs to be adapted in this PR if #21296 landed meanwhile.