Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
src: remove .h if -inl.h is already included#21381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE.
nodejs-github-bot commented Jun 18, 2018
danbev commented Jun 18, 2018
danbev commented Jun 18, 2018
node-test-commit-windows-fanned failure looks unrelatednot ok 491 parallel/test-worker-memory --- duration_ms: 1.413 severity: fail exitcode: 1 stack: |- Mismatched <anonymous> function calls. Expected exactly 1, actual 0. at Object.exports.mustCall (c:\workspace\node-test-binary-windows\test\common\index.js:428:10) at run (c:\workspace\node-test-binary-windows\test\parallel\test-worker-memory.js:21:28) at Worker.worker.on.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-worker-memory.js:22:5) at Worker.<anonymous> (c:\workspace\node-test-binary-windows\test\common\index.js:468:15) at Worker.emit (events.js:182:13) at Worker.[kOnExit] (internal/worker.js:270:10) at Worker.(anonymous function).onexit (internal/worker.js:226:51) ... |
bnoordhuis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice as an enhancement to have cpplint.py or check-imports.sh enforce this.
danbev commented Jun 19, 2018
Yeah, I what would make sense. I'll take a look but might not have time this week by the looks of things. |
ryzokuken commented Jun 19, 2018
@danbev if it's okay, I guess this could be landed and I could help out with the linting in a separate PR. |
danbev commented Jun 19, 2018
That would be great, thanks! |
danbev commented Jun 20, 2018
Landed in a71d5fc. |
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: #21381 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos commented Jun 20, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Should land cleanly on v10.x-staging after #21105 is backported |
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: #21381 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This commit removes the normal header file include if an internal one
is specified as per the CPP_STYLE_GUIDE.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes