move per-context changes from c++ to js#21518

devsnek · 2018-06-25T07:17:33Z

move the changes made to new contexts from c++ to js.

second commit adds a warning when Atomics.wake is used and changes Atomics.notify.name to notify

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2018-06-25T07:17:34Z

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/149/pipeline

addaleax · 2018-06-25T19:01:59Z

lib/internal/per_context.js

I’m not sure, is there any reason why we wouldn’t want to do a normal deprecation cycle for these (i.e. make this PR semver-major)?

I wasn't quite sure where to document it and like @rwaldon said it's not very widely used. I'm ok with removing the message though

should this still be considered semver major?

devsnek · 2018-06-27T19:05:55Z

CI https://ci.nodejs.org/job/node-test-pull-request/15655/

devsnek · 2018-06-27T22:15:49Z

landed in 759809f...dcb371f

PR-URL: #21518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

targos · 2018-06-28T18:50:57Z

@devsnek Be careful with the commit messages. per_context is not a subsystem.

devsnek · 2018-06-28T19:01:13Z

@targos i assumed once it was created it became a subsystem. what would the correct label have been?

addaleax · 2018-06-28T19:04:53Z

@devsnek As I understand it, subsystems for files under lib/ generally refer to public modules, and the rest would generally be considered lib?

The point of subsystems is that they make reading changelogs easier, because we group commits by them; if it’s not something that immediately affects users of Node.js but still touches the source files, lib or src would be appropriate imo

targos · 2018-06-28T19:07:03Z

@addaleax Thanks, that's along the lines of what I was writing :)

refack · 2018-06-29T16:32:35Z

~~@devsnek could you reopen this PR. I want to see the what Jenkins reported.~~
NM

Trott · 2018-06-29T16:40:16Z

It does appear that this landed with a red CI. I know it's sometimes painful to slog it out until you get to green or yellow, but I'd ask that we really work hard to do that. I'm bisecting right now because something broke the --without-intl build (which is what failed in the CI in this PR)...

Trott · 2018-06-29T16:48:50Z

d13cdd9 broke the build. So the red CI in this case wasn't an infrastructure issue but was in fact a test failure resulting from the change set.

Trott · 2018-06-29T16:54:10Z

PR to revert the one bad commit: #21587

Trott · 2018-06-29T17:05:30Z

Narrower alternative fix suggested by @devsnek and @refack in #21589

Trott · 2018-06-29T17:05:38Z

Narrower alternative fix suggested by @devsnek and @refack in #21589

Notable changes: * build: * Node.js should now be about 60% faster to startup than the previous version, thanks to the use V8's code cache feature for core modules. [#21405](#21405) * dns: * An experimental promisified version of the dns module is now available. Give it a try with `require('dns').promises`. [#21264](#21264) * fs: * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498) * lib: * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript specification ([reference](tc39/ecma262#1220)). Since Node.js now has experimental support for worker threads, we are being proactive and added a `notify` alias, while emitting a warning if `wake` is used. [#21413](#21413) [#21518](#21518) * n-api: * Add API for asynchronous functions. [#17887](#17887) * util: * `util.inspect` is now able to return a result instead of throwing when the maximum call stack size is exceeded during inspection. [#20725](#20725) * vm: * Add `script.createCachedData()`. This API replaces the `produceCachedData` option of the `Script` constructor that is now deprecated. [#20300](#20300) * worker: * Support for relative paths has been added to the `Worker` constructor. Paths are interpreted relative to the current working directory. [#21407](#21407) PR-URL: #21629

Notable changes: * dns: * An experimental promisified version of the dns module is now available. Give it a try with `require('dns').promises`. [#21264](#21264) * fs: * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498) * lib: * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript specification ([reference](tc39/ecma262#1220)). Since Node.js now has experimental support for worker threads, we are being proactive and added a `notify` alias, while emitting a warning if `wake` is used. [#21413](#21413) [#21518](#21518) * n-api: * Add API for asynchronous functions. [#17887](#17887) * util: * `util.inspect` is now able to return a result instead of throwing when the maximum call stack size is exceeded during inspection. [#20725](#20725) * vm: * Add `script.createCachedData()`. This API replaces the `produceCachedData` option of the `Script` constructor that is now deprecated. [#20300](#20300) * worker: * Support for relative paths has been added to the `Worker` constructor. Paths are interpreted relative to the current working directory. [#21407](#21407) PR-URL: #21629

- nodejs/node#21518

devsnek requested a review from addaleax June 25, 2018 07:17

devsnek requested a review from hashseed June 25, 2018 07:17

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 25, 2018

devsnek changed the title ~~Refactor/per context things~~move per-context changes from c++ to jsJun 25, 2018

devsnek force-pushed the refactor/per-context-things branch 2 times, most recently from 907720a to 2f8157aCompare June 25, 2018 07:41

bnoordhuis approved these changes Jun 25, 2018
View reviewed changes

addaleax reviewed Jun 25, 2018
View reviewed changes

addaleax approved these changes Jun 25, 2018
View reviewed changes

devsnek added 2 commits June 27, 2018 13:42

src: move context bootstrap to js
77fc500

per_context: add warning to Atomics.wake
e681bea

devsnek force-pushed the refactor/per-context-things branch from 2f8157a to e681beaCompare June 27, 2018 19:03

devsnek closed this Jun 27, 2018

devsnek deleted the refactor/per-context-things branch June 27, 2018 22:15

devsnek added a commit that referenced this pull request Jun 27, 2018
src: move context bootstrap to js
d13cdd9
PR-URL: #21518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

devsnek added a commit that referenced this pull request Jun 27, 2018
per_context: add warning to Atomics.wake
dcb371f
PR-URL: #21518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

targos pushed a commit that referenced this pull request Jun 28, 2018
src: move context bootstrap to js
eb8d60b
PR-URL: #21518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

targos pushed a commit that referenced this pull request Jun 28, 2018
per_context: add warning to Atomics.wake
0a1e8e0
PR-URL: #21518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

targos mentioned this pull request Jul 3, 2018
v10.6.0 proposal #21629
Merged

alexeykuzmin added a commit to electron/node that referenced this pull request Sep 3, 2018
fixup! chore: add GN build files
5d31f85
- nodejs/node#21518

Uh oh!

move per-context changes from c++ to js#21518

move per-context changes from c++ to js #21518

Uh oh!

Conversation

devsnek commented Jun 25, 2018

Checklist

Uh oh!

nodejs-github-bot commented Jun 25, 2018

Uh oh!

addaleaxJun 25, 2018

Choose a reason for hiding this comment

Uh oh!

devsnekJun 25, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devsnekJun 26, 2018

Choose a reason for hiding this comment

Uh oh!

devsnek commented Jun 27, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devsnek commented Jun 27, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 28, 2018

Uh oh!

devsnek commented Jun 28, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Jun 28, 2018

Uh oh!

targos commented Jun 28, 2018

Uh oh!

refack commented Jun 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Jun 29, 2018

Uh oh!

Trott commented Jun 29, 2018

Uh oh!

Trott commented Jun 29, 2018

Uh oh!

Trott commented Jun 29, 2018

Uh oh!

Trott commented Jun 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

devsnekJun 25, 2018•
edited
Loading

devsnek commented Jun 27, 2018•
edited
Loading

devsnek commented Jun 27, 2018•
edited
Loading

devsnek commented Jun 28, 2018•
edited
Loading

refack commented Jun 29, 2018•
edited
Loading