build: make --shared-[...]-path work on Windows#21530
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build ContributorAuthor
nornagon commented Jun 25, 2018
Hmm, actually this doesn't work properly because gyp automatically adds |
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ```
nornagonforce-pushed the win-shared-libpath branch from c4975e5 to e8263cbComparenornagon added a commit to electron/node that referenced this pull request Jun 25, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
MarshallOfSound pushed a commit to electron/node that referenced this pull request Jun 27, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
Member
addaleax commented Jul 18, 2018
@nornagon I can’t really tell, but what’s the status of this? 🙂 |
ContributorAuthor
nornagon commented Jul 18, 2018
My comment about "this doesn't work properly" referred to an older version of this patch that github doesn't seem to show. The current version of the patch works fine and is being used in Electron's fork of node (see electron/node#41). |
addaleax approved these changes Jul 19, 2018
Member
addaleax commented Jul 19, 2018
CI: https://ci.nodejs.org/job/node-test-pull-request/15946/ /cc @nodejs/platform-windows |
addaleax added the author ready ContributorAuthor
nornagon commented Jul 19, 2018
The test that failed in ci was |
jasnell approved these changes Jul 20, 2018
joaocgreis approved these changes Jul 23, 2018
Member
joaocgreis commented Jul 23, 2018
codebytere pushed a commit to electron/node that referenced this pull request Jul 30, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
Contributor
maclover7 commented Aug 11, 2018
jasnell pushed a commit that referenced this pull request Aug 12, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` PR-URL: #21530 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
Member
jasnell commented Aug 12, 2018
Landed in 83ab3bf |
rvagg pushed a commit that referenced this pull request Aug 13, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` PR-URL: #21530 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
codebytere pushed a commit to electron/node that referenced this pull request Aug 29, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
codebytere pushed a commit to electron/node that referenced this pull request Sep 1, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
alexeykuzmin pushed a commit to electron/node that referenced this pull request Sep 5, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
codebytere pushed a commit to electron/node that referenced this pull request Sep 5, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
codebytere pushed a commit to electron/node that referenced this pull request Sep 13, 2018
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` See nodejs/node#21530
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
The `-L<path>` syntax isn't recognized by link.exe, and gyp doesn't translate it properly. Without this, link.exe generates the following warning and fails to link: ``` LINK : warning LNK4044: unrecognized option '/LC:/Users/nornagon/...'; ignored ``` PR-URL: nodejs/node#21530 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-L<path>syntax isn't recognized by link.exe, and gyp doesn'ttranslate it properly. Without this, link.exe generates the following
warning and fails to link:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes