test: check type for Worker filename argument#21620
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add test to check type for first argument of Worker to increase coverage.
lpinca approved these changes Jul 2, 2018
Member
lpinca commented Jul 2, 2018
lpinca added the author ready 
trivikr approved these changes Jul 2, 2018
tniessen approved these changes Jul 2, 2018
cjihrig approved these changes Jul 2, 2018
benjamingr approved these changes Jul 2, 2018
JungMinu approved these changes Jul 3, 2018
TimothyGu approved these changes Jul 3, 2018
Member
trivikr commented Jul 4, 2018
Landed in 0b2ad91 |
trivikr pushed a commit that referenced this pull request Jul 4, 2018
Add test to check type for first argument of Worker to increase coverage. PR-URL: #21620 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
targos pushed a commit that referenced this pull request Jul 4, 2018
Add test to check type for first argument of Worker to increase coverage. PR-URL: #21620 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
This was referenced Jul 18, 2018
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to check type for first argument of Worker to increase
coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes