inspector: expose original console

[mcollina]

Adds require('inspector').console, mapping it to the original
global.console of V8. This enables applications to send messages to
the inspector console programmatically.

Fixes: #21651

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/211/pipeline

[mcollina]

cc @targos@devsnek

[devsnek]

you might want to mention that node's console and v8's debug console don't have API parity. (e.g. a method might exist for one that doesn't with the other)

[TimothyGu]

LGTM after the CI failures have been sorted out.

[TimothyGu]

No need for extraneous new lines.

[TimothyGu]

This should also check if stdout is empty.

[Trott]

Here's the CI failure:

https://ci.nodejs.org/job/node-test-commit-linuxone/2755/nodes=rhel72-s390x/console

11:08:23 not ok 490 parallel/test-eslint-require-buffer11:08:23 ---11:08:23 duration_ms: 0.65011:08:23 severity: fail11:08:23 stack: |-11:08:23 /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:14811:08:23 throw err;11:08:23 ^11:08:23 11:08:23 AssertionError [ERR_ASSERTION]: 'Use const{Buffer } = require(\'buffer\'); at the beginning of this file' strictEqual 'Use const Buffer = require(\'buffer\').Buffer; at the beginning of this file' ('Use const{Buffer } = require(\'buffer\'); at the beginning of this file' strictEqual 'Use const Buffer = require(\'buffer\').Buffer; at the beginning of this file')11:08:23 at assertMessageMatches (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:442:24)11:08:23 at testInvalidTemplate (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:494:29)11:08:23 at Function.RuleTester.it (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:581:25)11:08:23 at Function.itDefaultHandler (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:143:23)11:08:23 at test.invalid.forEach.invalid (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:580:32)11:08:23 at Array.forEach (<anonymous>)11:08:23 at Function.RuleTester.describe (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:579:30)11:08:23 at Function.describeDefaultHandler (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:160:19)11:08:23 at Function.RuleTester.describe (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:578:24)11:08:23 at Function.describeDefaultHandler (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/node_modules/eslint/lib/testers/rule-tester.js:160:19)11:08:23 ...

Sure seems unrelated. This will need a full CI anyway, so we'll see what happens when a full CI is run. (This was the automatic lite CI.)

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/15734/

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/15735/

[mcollina]

There are two failures, the first is #21233:

04:46:16 not ok 572 sequential/test-inspector-stop-profile-after-done 04:46:16 --- 04:46:16 duration_ms: 0.739 04:46:16 severity: fail 04:46:16 exitcode: 1 04:46:16 stack: |- 04:46:16 [test] Connecting to a child Node process 04:46:16 [test] Testing /json/list 04:46:16 [err] Debugger listening on ws://127.0.0.1:54651/3215a22e-09d3-4951-bd7c-11a8d2b1955b 04:46:16 [err] For help, see: https://nodejs.org/en/docs/inspector 04:46:16 [err] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [out]{} 04:46:16 [out] 04:46:16 [err] Debugger attached. 04:46:16 [err] Waiting for the debugger to disconnect... 04:46:16 [err] 04:46:16{AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B: 04:46:16 + expected - actual 04:46:16 04:46:16 - 3221225477 04:46:16 + 0 04:46:16 at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-stop-profile-after-done.js:28:10) 04:46:16 at process._tickCallback (internal/process/next_tick.js:68:7) 04:46:16 generatedMessage: true, 04:46:16 name: 'AssertionError [ERR_ASSERTION]', 04:46:16 code: 'ERR_ASSERTION', 04:46:16 actual: 3221225477, 04:46:16 expected: 0, 04:46:16 operator: 'strictEqual' } 04:46:16 1 04:46:16 ... 

And the second is definitely unrelated:

04:44:45 not ok 494 parallel/test-worker-relative-path-double-dot 04:44:45 --- 04:44:45 duration_ms: 120.98 04:44:45 severity: fail 04:44:45 exitcode: 1 04:44:45 stack: |- 04:44:45 timeout 

@Trott I think this can land.

[Trott]

Here's a re-run of Windows (the only platform that failed):

https://ci.nodejs.org/job/node-test-commit-windows-fanned/19126/

[mcollina]

test-https-foafssl.js failed. I've hit resume, but probably I've caused more harm than good.

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/15746/ (maybe with more luck)

[mcollina]

Landed in 19795d8

[mcollina]

@targos this should land after #21378 or a backport PR being created to work around it.