test: add test of fs.promises write for non-string buffers#21708
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fhinkel approved these changes Jul 8, 2018
Leko approved these changes Jul 8, 2018
lpinca approved these changes Jul 9, 2018
cjihrig approved these changes Jul 10, 2018
jasnell approved these changes Jul 10, 2018
Member
addaleax commented Jul 10, 2018
addaleax added the author ready 
BridgeAR approved these changes Jul 13, 2018
Member
addaleax commented Jul 13, 2018
Windows CI re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19274/ |
Member
addaleax commented Jul 15, 2018
addaleax pushed a commit that referenced this pull request Jul 15, 2018
PR-URL: #21708 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 15, 2018
PR-URL: #21708 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jul 16, 2018
PR-URL: #21708 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jul 16, 2018
PR-URL: #21708 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced Jul 18, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes