test: check arg type for dnsPromises.resolve to increase coverage.#22000
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Jul 27, 2018
cjihrig approved these changes Jul 27, 2018
jasnell approved these changes Jul 27, 2018
lpinca approved these changes Jul 27, 2018
trivikr approved these changes Aug 1, 2018
Member
trivikr commented Aug 1, 2018
trivikr added the author ready Member
trivikr commented Aug 2, 2018
Contributor
maclover7 commented Aug 3, 2018
Hopefully one last resume CI to fix Windows: https://ci.nodejs.org/job/node-test-pull-request/16162/ |
Contributor
maclover7 commented Aug 4, 2018
shisamaforce-pushed the test-dns-resolve-type-check branch from b5ed53e to cbec284Compare
ContributorAuthor
@trivikr@maclover7 Thank you to run CI again. But CI failed. I'm not sure that rebasing this will resolve the problems but I tried to rebase. If you don't mind, could you please run CI again? |
Member
trivikr commented Aug 5, 2018
trivikr approved these changes Aug 7, 2018
Member
trivikr commented Aug 7, 2018
Landed in 0b85435 |
trivikr pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #22000 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22000 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22000 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes