test: Remove third argument from assert.strictEqual()#22051
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual().
Trott approved these changes Aug 1, 2018
Member
Trott commented Aug 1, 2018
apapirovski approved these changes Aug 1, 2018
Contributor
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
LGTM but do the comments actually help? I would argue we should remove them too.
jasnell approved these changes Aug 1, 2018
trivikr approved these changes Aug 1, 2018
cjihrig approved these changes Aug 1, 2018
maclover7 approved these changes Aug 1, 2018
lpinca approved these changes Aug 1, 2018
BridgeAR approved these changes Aug 1, 2018
BridgeAR added fast-track Member
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16142/ (edit @maclover7: ✔️) |
Contributor
maclover7 commented Aug 3, 2018
Landed in 8d15f69, congrats on your first pull request to Node.js!! ❤️ 💚 💙 💛 💜 |
targos pushed a commit that referenced this pull request Aug 4, 2018
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual(). PR-URL: #22051 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Aug 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In file test/parallel/test-stream-transform-final.js the ten calls to
assert.strictEqual() use a string literal as third argument. When
a AssertionError occurs, it reports the string literal and not the
first two arguments, so the third agrument is removed and made a
comment just above the call to assert.strictEqual().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes