Skip to content

Conversation

@mmarchini
Copy link
Contributor

@mmarchinimmarchini commented Aug 1, 2018

Original commit message:

[postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#54768} 

Refs: v8/v8@09bca09

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Matheus Marchini added 2 commits August 1, 2018 15:09
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54768} Refs: v8/v8@09bca09
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency. labels Aug 1, 2018
@mmarchinimmarchini changed the title V8 09bca095deps: cherry-pick 09bca09 from upstream V8Aug 1, 2018
@mmarchini
Copy link
ContributorAuthor

mmarchini commented Aug 1, 2018

@jasnell
Copy link
Member

Can you please include the original commit message in the PR description above?

@mmarchini
Copy link
ContributorAuthor

@jasnell done!

@mmarchini
Copy link
ContributorAuthor

Landed in a4c1cf5

mmarchini pushed a commit that referenced this pull request Aug 6, 2018
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#54768} Refs: v8/v8@09bca09 PR-URL: #22068 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@targos
Copy link
Member

Should land with or after #21668 on v10.x-staging

@targos
Copy link
Member

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

@mmarchini
Copy link
ContributorAuthor

Should land with or after #21668 on v10.x-staging

After, since this wasn't included in V8 6.8. Btw, I checked and this lands cleanly on v10.x-staging (at least for now, let's see after #21668 lands)

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

@targos
Copy link
Member

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

It happens sometimes, when master already had the bump from another PR. Instead of creating a conflict, git just makes the change a no-op.

@mmarchini
Copy link
ContributorAuthor

Marked as dont-land-on-v8.x since SCOPE_INFO_TYPE, FIRST_CONTEXT_TYPE and LAST_CONTEXT_TYPE don't exist on V8 6.2.

targos pushed a commit that referenced this pull request Aug 11, 2018
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#54768} Refs: v8/v8@09bca09 PR-URL: #22068 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@rvaggrvagg mentioned this pull request Aug 13, 2018
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54768} Refs: v8/v8@09bca09 PR-URL: nodejs#22068 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54768} Refs: v8/v8@09bca09 PR-URL: nodejs#22068 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). [email protected], [email protected] Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#54768} Refs: v8/v8@09bca09 PR-URL: nodejs/node#22068 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.post-mortemIssues and PRs related to the post-mortem diagnostics of Node.js.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mmarchini@nodejs-github-bot@jasnell@targos@BridgeAR