lib: extract validateString validator#22101
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot added the lib / src 
ghost reviewed Aug 3, 2018
There was a problem hiding this comment.
What about trying to create another new function called "isEmptyString" to check whether your string value is empty:
function isEmptyString (s){return (typeof s === 'string' && s.trim() === '')} Most of your functions requires a param value that isn't null or empty.
Maybe when both of the things meet, we can continue going on.
ContributorAuthor
maclover7 commented Aug 3, 2018
@Maledong Not sure if this is the case -- where do you see this check? I'd rather not add new validations in this PR, since that would be a |
Member
@Maledong Arguably |
joyeecheung approved these changes Aug 3, 2018
Member
joyeecheung commented Aug 3, 2018
targos approved these changes Aug 3, 2018
lib/net.js Outdated
| if(typeofpath!=='string'){ | ||
| thrownewERR_INVALID_ARG_TYPE('options.path','string',path); | ||
| } | ||
| validateString(path,'path'); |
Member
There was a problem hiding this comment.
Name changed from "options.path" to "path". I'm on mobile so can't check which one is correct.
ContributorAuthor
There was a problem hiding this comment.
I think changing the name was a mistake, but going to put this back to options.path instead of path to make sure this is definitely not semver-major :)
trivikr approved these changes Aug 3, 2018
cjihrig approved these changes Aug 3, 2018
apapirovski approved these changes Aug 3, 2018
lpinca approved these changes Aug 3, 2018
jasnell approved these changes Aug 3, 2018
Member
Trott commented Aug 4, 2018
CI again: https://ci.nodejs.org/job/node-test-pull-request/16182/ (Didn't use Resume Build because windows-fanned failed and Resume Build does not cooperate with windows-fanned.) |
ContributorAuthor
maclover7 commented Aug 4, 2018
ContributorAuthor
maclover7 commented Aug 7, 2018
targos approved these changes Aug 7, 2018
Member
lpinca commented Aug 7, 2018
Still LGMT. |
Pulls out a common argument validator to `internal/validators`
ContributorAuthor
maclover7 commented Aug 7, 2018
Landed in e570ae7, thank you for the reviews! |
maclover7 added a commit that referenced this pull request Aug 7, 2018
Pulls out a common argument validator to `internal/validators` PR-URL: #22101 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 11, 2018
Pulls out a common argument validator to `internal/validators` PR-URL: #22101 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
2 tasks
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 9, 2018
PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
2 tasks
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
PR-URL: nodejs#24960 Refs: nodejs#22101 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
PR-URL: #24960 Refs: #22101 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24960 Refs: nodejs#22101 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Pulls out a common argument validator to `internal/validators` PR-URL: nodejs/node#22101 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls out a common argument validator to
internal/validatorsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes