Remove unused 3rd argument in assert.strictEqual()#22113
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added node-api 
addaleax approved these changes Aug 3, 2018
jasnell approved these changes Aug 3, 2018
Trott requested changes Aug 3, 2018
yahavf6force-pushed the yahavf6-removeUnusedSSrtingError040818 branch from c71cacc to c188ca0Compare
ContributorAuthor
yahavf6 commented Aug 4, 2018
PR updated |
cjihrig approved these changes Aug 4, 2018
ContributorAuthor
yahavf6 commented Aug 4, 2018 via email
Hey all, I've updated my PR בתאריך שבת, 4 באוג׳ 2018 ב-20:31 מאת Colin Ihrig < [email protected]>: … ***@***.**** approved this pull request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#22113 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgaT7R2XRmesq3Op0ydmB8IWAdEfUKi6ks5uNdqJgaJpZM4Vuo9T> . |
lpinca approved these changes Aug 4, 2018
maclover7 approved these changes Aug 4, 2018
Contributor
maclover7 commented Aug 4, 2018
Trott approved these changes Aug 4, 2018
starkwang approved these changes Aug 5, 2018
benjamingr approved these changes Aug 5, 2018
Member
benjamingr commented Aug 5, 2018
ContributorAuthor
yahavf6 commented Aug 7, 2018
Let's merge? |
maclover7 added the author ready Trott pushed a commit to Trott/io.js that referenced this pull request Aug 7, 2018
PR-URL: nodejs#22113 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
Trott commented Aug 7, 2018
Landed in 1284fa2. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22113 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22113 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 9 contains a call to assert.strictEqual(). It has a string literal as the third argument. Unfortunately, that means that if there is an AssertionError, the value of status (the first argument) will not be reported. The third argument here is not adding any value (and in fact is reporting the wrong thing in the event of an AssertionError) so removed it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes