crypto: simplify state failure handling#22131
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer.
nodejs-github-bot added c++ 
MemberAuthor
tniessen commented Aug 4, 2018
cc @nodejs/crypto |
Member
Trott commented Aug 5, 2018
@nodejs/security-wg |
maclover7 approved these changes Aug 5, 2018
tniessen added the author ready MemberAuthor
lpinca approved these changes Aug 5, 2018
Member
trivikr commented Aug 8, 2018
Landed in 77ac962 |
trivikr pushed a commit that referenced this pull request Aug 8, 2018
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer. PR-URL: #22131 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Aug 11, 2018
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer. PR-URL: #22131 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This was referenced Aug 16, 2018
tniessen removed the author ready firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer. PR-URL: nodejs/node#22131 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is more intuitive to return
true/falsethanundefined/false. This also simplifies handling in the JS layer and removes two control-flow branches from C++.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes