src: remove unused env strings#22137
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
tniessen approved these changes Aug 5, 2018
devsnek approved these changes Aug 5, 2018
Member
tniessen commented Aug 5, 2018
Please 👍 here if you approve fast-tracking. |
tniessen added the author ready Member
tniessen commented Aug 5, 2018
addaleax approved these changes Aug 5, 2018
targos approved these changes Aug 5, 2018
trivikr approved these changes Aug 5, 2018
lpinca approved these changes Aug 5, 2018
tniessen pushed a commit that referenced this pull request Aug 5, 2018
user_string: Usage removed in 4e05952 onstop_string: Usage removed in 7b46e17 max_old_space_size_string: Added in 0df031a, never used max_semi_space_size_string: Added in 0df031a, never used enter_string: Usage removed in eeede3b PR-URL: #22137 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 6, 2018
user_string: Usage removed in 4e05952 onstop_string: Usage removed in 7b46e17 max_old_space_size_string: Added in 0df031a, never used max_semi_space_size_string: Added in 0df031a, never used enter_string: Usage removed in eeede3b PR-URL: #22137 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Aug 16, 2018
This was referenced May 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_string: Usage removed in 4e05952
onstop_string: Usage removed in 7b46e17
max_old_space_size_string: Added in 0df031a, never used
max_semi_space_size_string: Added in 0df031a, never used
enter_string: Usage removed in eeede3b
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes