Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
tools: update to mdast-util-to-hast v3.0.2#22140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nodejs-github-bot commented Aug 5, 2018
vsemozhetbyt commented Aug 5, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There is good news. This PR fix two known regressions and one previously unknown regression:
|
vsemozhetbyt commented Aug 5, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There is bad news. This PR introduces one new regression. If a heading has two consecutive optional parameters in square brackets, they are not rendered as links, but some preprocess cleaning is done as if they are links:
Compare these examples before and after this PR: |
vsemozhetbyt commented Aug 5, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
And there is good bad news) Comparing the diff helps to find out one issue that is differently exposed before and after this PR.
Compare the doc from the old toolchain: https://nodejs.org/docs/latest-v8.x/api/dns.html#dns_dns_resolvetxt_hostname_callback One of the concerned code fragments: Lines 138 to 141 in 28c70ac
|
rubys commented Aug 5, 2018
I know what's going on. I'll try to see if i can create another patch for mdast-util-to-hast. |
rubys commented Aug 8, 2018
Three pull requests created to solve (most) of the problems noted above:
The 2-dimensional array appears to be a separate problem in that remark, et. al., appears to be doing the right thing. Once the above fixes land, I'll look into fixing that problem too. |
Trott commented Aug 10, 2018
Should this update the corresponding |
rubys commented Aug 10, 2018
@Trott will do... once the above three patches are resolved. But first, there are yaks that need shaving: syntax-tree/mdast#23 (comment) |
Preferred long term fix can be found at: nodejs#22140
quick fix for #22065 Preferred long term fix can be found at: #22140 PR-URL: #22084Fixes: #22065 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
quick fix for #22065 Preferred long term fix can be found at: #22140 PR-URL: #22084Fixes: #22065 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
jasnell commented Sep 10, 2018
Ping @rubys ... what's the status on this one? |
trivikr commented Oct 1, 2018
The PRs listed in #22140 (comment) need a follow-up |
Trott commented Dec 5, 2018
@rubys Looks like all upstream yaks have been shaved and this can be rebased, run through CI, and hopefully landed? |
8f1c6ab to 6118207CompareTrott commented Dec 14, 2018
Took the liberty of rebasing. Hope that's OK. Still have to install the upstream dependencies that have been updated and run through CI? |
BridgeAR commented Mar 10, 2019
6118207 to ade009eComparerefack commented Mar 10, 2019
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: nodejs#22140 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ade009e to cba2c7aCompareSee syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
quick fix for #22065 Preferred long term fix can be found at: nodejs/node#22140 PR-URL: nodejs/node#22084Fixes: nodejs/node#22065 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>





See syntax-tree/mdast-util-to-hast#21
Fixes#22065
Note: I updated all of the tools/doc dependencies, not just this one,
and removed the previous workaround that was in place until this change
landed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes