Skip to content

deps: V8: backport c608122b from upstream#22210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BridgeAR wants to merge 1 commit into from
Closed

deps: V8: backport c608122b from upstream #22210

BridgeAR wants to merge 1 commit into from

Conversation

@BridgeAR
Copy link
Member

@BridgeARBridgeAR commented Aug 9, 2018

Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{#54821}

This backport fixes a proxy issue with the object ->GetPropertyNames API. This is very useful to improve the performance of some APIs significantly. It can be applied for util.comparison and util.inspect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
deps: V8: backport c608122b from upstream
7b08fee
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54821}
@BridgeARBridgeAR requested a review from targosAugust 9, 2018 12:29
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 9, 2018

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/473/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Aug 9, 2018
mcollina
mcollina approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Aug 9, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16302/
V8-CI https://ci.nodejs.org/job/node-test-commit-v8-linux/1590/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Aug 11, 2018

It would be nice to get another review @nodejs/v8-update

@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Aug 13, 2018

PTAL @nodejs/v8-update

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 13, 2018
@BridgeAR
deps: backport c608122b from upstream
c4007f0
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#54821} PR-URL: nodejs#22210 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Aug 13, 2018

Landed in c4007f0 🎉

rvagg pushed a commit that referenced this pull request Aug 15, 2018
@BridgeAR@rvagg
deps: backport c608122b from upstream
4dfafac
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{#54821} PR-URL: #22210 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
@rvaggrvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeARBridgeAR deleted the backport-c608122b branch January 20, 2020 11:34
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@BridgeAR@rvagg
deps: backport c608122b from upstream
fcf422e
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{#54821} PR-URL: nodejs/node#22210 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@targostargosAwaiting requested review from targos

@MylesBorinsMylesBorinsAwaiting requested review from MylesBorins

@addaleaxaddaleaxAwaiting requested review from addaleax

@TimothyGuTimothyGuAwaiting requested review from TimothyGu

+1 more reviewer

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BridgeAR@nodejs-github-bot@mcollina@devsnek