benchmark: improve assert benchmarks#22211
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed.
nodejs-github-bot added assert 
apapirovski approved these changes Aug 9, 2018
benjamingr approved these changes Aug 9, 2018
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Thanks for splitting - changes LGTM + nice work cutting down the LoC
Member
mcollina commented Aug 9, 2018
Can you run the benchmarks before/after? How the output changes? |
MemberAuthor
BridgeAR commented Aug 9, 2018
Benchmark new: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/223/ Benchmark old: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/224/ (just a different PR without this change). I do not run a full CI here as it does not seem to be necessary. |
BridgeAR added the author ready 4 tasks
trivikr approved these changes Aug 12, 2018
jasnell approved these changes Aug 12, 2018
Member
jasnell commented Aug 12, 2018
MemberAuthor
BridgeAR commented Aug 13, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 13, 2018
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed. PR-URL: nodejs#22211 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
BridgeAR commented Aug 13, 2018
Landed in 5442c28 🎉 |
rvagg pushed a commit that referenced this pull request Aug 15, 2018
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed. PR-URL: #22211 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed. PR-URL: nodejs/node#22211 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the runtime and makes sure the strict and loose options
can be tested individually and reduces the code size.
Besides that a few redundant cases were removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes