test: improve test coverage for comparisons#22212
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
apapirovski approved these changes Aug 9, 2018
benjamingr approved these changes Aug 9, 2018
BridgeAR added author ready 
MemberAuthor
BridgeAR commented Aug 9, 2018
BridgeAR added the author ready 
trivikr approved these changes Aug 9, 2018
lpinca approved these changes Aug 9, 2018
jasnell approved these changes Aug 9, 2018
BridgeARforce-pushed the improve-assert-coverage branch from f48b36a to df29a1dCompareMemberAuthor
BridgeAR commented Aug 10, 2018
Member
jasnell commented Aug 12, 2018
Rerun custom-suites CI:https://ci.nodejs.org/job/node-test-commit-custom-suites/628/ |
jasnell pushed a commit that referenced this pull request Aug 12, 2018
PR-URL: #22212 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Aug 12, 2018
Landed in c3bd651 |
rvagg pushed a commit that referenced this pull request Aug 13, 2018
PR-URL: #22212 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22212 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few last cases that were not covered so far.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes