src: fix integer overflow in GetNow#22214
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
addaleax approved these changes Aug 9, 2018
addaleax reviewed Aug 9, 2018
| uint64_t now = uv_now(event_loop()); | ||
| CHECK_GE(now, timer_base()); | ||
| now -= timer_base(); | ||
| if (now <= 0xffffffff) |
ContributorAuthor
There was a problem hiding this comment.
It shouldn't matter in this case, right? I thought they were equivalent since this won't fit into an int and the next type is unsigned int.
Member
There was a problem hiding this comment.
Okay, I looked it up – without the suffix it is still signed, but it’s a long int in that case, so we’re probably fine here. :)
cjihrig approved these changes Aug 9, 2018
ContributorAuthor
apapirovski commented Aug 9, 2018
bmeck approved these changes Aug 9, 2018
mmarchini approved these changes Aug 9, 2018
TimothyGu approved these changes Aug 9, 2018
lpinca approved these changes Aug 9, 2018
Member
This was introduced in #18486 and shouldn't affect versions prior to 10.0.0, correct? |
ChALkeR added dont-land-on-v6.x timers 
BridgeAR approved these changes Aug 9, 2018
ChALkeR approved these changes Aug 9, 2018
jasnell approved these changes Aug 9, 2018
benjamingr approved these changes Aug 9, 2018
maclover7 added the author ready 
trivikr approved these changes Aug 12, 2018
Member
trivikr commented Aug 12, 2018
Landed in 01a160a |
trivikr pushed a commit that referenced this pull request Aug 12, 2018
PR-URL: #22214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Aug 12, 2018
PR-URL: #22214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
This was referenced Aug 31, 2018
nkbt reviewed Oct 9, 2018
| uint64_t now = uv_now(event_loop()); | ||
| CHECK_GE(now, timer_base()); | ||
| now -= timer_base(); | ||
| if (now <= 0xffffffff) |
There was a problem hiding this comment.
Does this mean that the bug still exists for numbers in 2^31 .. 2^32 range?
Member
There was a problem hiding this comment.
@nkbt This PR fixed the bug for those numbers – all others should remain the same
There was a problem hiding this comment.
Thanks, I was not sure if NewFromUnsigned does exactly that
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22214 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, that was stupid... This check used to be for
0xfffffffwhich was wrong (oneftoo few) so that got fixed, but that change was made based on it being cast to a uint32_t (2**32-1) rather than the correct int32_t. Of course,Integer::Newjust happily accepted it despite not actually being able to handle it. Fun stuff...Fixes#22149
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes