tls: refactor variable declarations#22219
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Aug 9, 2018
Member
Trott commented Aug 9, 2018
jasnell approved these changes Aug 9, 2018
Trott added the author ready 
cjihrig approved these changes Aug 9, 2018
trivikr approved these changes Aug 12, 2018
devsnek approved these changes Aug 12, 2018
aduh95 reviewed Aug 12, 2018
| varparts=s.split('\n'); | ||
| constout=Object.create(null); | ||
| constparts=s.split('\n'); | ||
| for(vari=0,len=parts.length;i<len;i++){ |
Contributor
There was a problem hiding this comment.
Shouldn't we replace the for loop by a for-of loop?
Member
There was a problem hiding this comment.
Using the traditional for loop is still significantly faster than for-of and is fairly idiomatic still within Node.js core js.
maclover7 approved these changes Aug 12, 2018
jasnell pushed a commit that referenced this pull request Aug 12, 2018
PR-URL: #22219 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Member
jasnell commented Aug 12, 2018
Landed in 74d3363 |
rvagg pushed a commit that referenced this pull request Aug 13, 2018
PR-URL: #22219 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]>
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22219 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change var to const
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes