doc: add subprocess.ref() and subprocess.unref() methods#22220
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added child_process 
addaleax approved these changes Aug 9, 2018
bengl approved these changes Aug 9, 2018
bengl reviewed Aug 9, 2018
doc/api/child_process.md Outdated
Member
There was a problem hiding this comment.
Shouldn't this be 0.7.10? And same for unref.
doc/api/child_process.md Outdated
Member
There was a problem hiding this comment.
Maybe `for a given `subprocess` to exit`?
doc/api/child_process.md Outdated
Member
There was a problem hiding this comment.
between the child and the parent?
jasnell approved these changes Aug 9, 2018
tlhunterforce-pushed the child-process-doc branch from cb9e2d8 to ebbf8e6Compare
TimothyGu approved these changes Aug 10, 2018
cjihrig approved these changes Aug 10, 2018
sagirk approved these changes Aug 10, 2018
Contributor
sagirk left a comment
sagirk left a comment There was a problem hiding this comment.
LGTM! 🎉
A few minor nits below.
doc/api/child_process.md Outdated
Contributor
There was a problem hiding this comment.
nit: ... before exiting itself. reads better, IMHO.
doc/api/child_process.md Outdated
Contributor
There was a problem hiding this comment.
nit: forcing instead of allowing seems to be the right word here.
doc/api/child_process.md Outdated
Contributor
There was a problem hiding this comment.
nit: given the context, usage of the word process to describe parent and child can be safely omitted.
tlhunterforce-pushed the child-process-doc branch from ebbf8e6 to 6b97a9aCompare
vsemozhetbyt approved these changes Aug 10, 2018
Contributor
vsemozhetbyt commented Aug 10, 2018
Contributor
vsemozhetbyt commented Aug 10, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt added author ready Contributor
vsemozhetbyt commented Aug 10, 2018
Landed in 7b1f3a4 |
vsemozhetbyt pushed a commit that referenced this pull request Aug 10, 2018
PR-URL: #22220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the
subprocess.ref()andsubprocess.unref()methods. The latter method does appear in the documentation as a side node in theoptions.detachedsection while the prior does not appear anywhere.Neither takes an argument nor has a return. I copied the documentation for
unreffrom the existingdetacheddocs. This is now redundant, perhaps the content should be removed fromdetachedand a link be added toref.The introduction version number should be correct, see
git log v0.7.10to confirm.Checklist