doc: add missing argv0 option for child_process.spawnSync#22231
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added child_process 
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Hi, @thw0rted. Welcome, and thanks for the pull request. It looks good to me.
It might be out of scope for this change, but I think the options should be alphabetized. Maybe if you're eager to do a second pull request or something.
/ping @nodejs/child_process @nodejs/documentation for reviews
Trott commented Aug 10, 2018
Trott added the author ready 
BridgeAR commented Aug 10, 2018
Having them alphabetically would be nice but in that case the other entry has to be moved as well. This is in sync with the other documentation. |
trivikr commented Aug 11, 2018
Thank you @thw0rted for your contribution. The author for the last commit can be updated by following these steps |
vsemozhetbyt commented Aug 11, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt added the fast-track vsemozhetbyt commented Aug 12, 2018
Landed in 1f32cca |
PR-URL: #22231 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #22231 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: nodejs/node#22231 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
8 participants
The child_process docs include
argv0as an option forspawnbut notspawnSync. This is a documentation oversight, because the actual functions share the same options parsing logic.Checklist