Skip to content

doc: clarify http2 docs around class exports#22247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 1 commit into from
Closed

doc: clarify http2 docs around class exports #22247

jasnell wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Aug 10, 2018

Fixes: #21434

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2018

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/503/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 10, 2018
@jasnelljasnell requested a review from mcollinaAugust 10, 2018 18:50
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 11, 2018
@jasnell
Copy link
MemberAuthor

jasnell commented Aug 11, 2018

Please 👍 to fast-track

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Aug 11, 2018
View reviewed changes
doc/api/http2.md Outdated
Copy link
Contributor

@vsemozhetbytvsemozhetbytAug 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the -> The.

doc/api/http2.md Outdated
Copy link
Contributor

@vsemozhetbytvsemozhetbytAug 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

trivikr
trivikr reviewed Aug 12, 2018
View reviewed changes
doc/api/http2.md Outdated
Copy link
Member

@trivikrtrivikrAug 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo . th# -> #

Copy link
MemberAuthor

@jasnelljasnellAug 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grr... sigh.

@jasnell
Copy link
MemberAuthor

jasnell commented Aug 12, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/531/

gdams
gdams approved these changes Aug 12, 2018
View reviewed changes
Copy link
Member

@gdamsgdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member

gdams commented Aug 12, 2018•
edited
Loading

landed in: d3d5982

@gdamsgdams closed this Aug 12, 2018
gdams pushed a commit that referenced this pull request Aug 12, 2018
@jasnell
doc: clarify http2 docs around class exports
d3d5982
PR-URL: #22247Fixes: #21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@rvaggrvagg mentioned this pull request Aug 13, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 13, 2018
@jasnell@rvagg
doc: clarify http2 docs around class exports
9a31fdc
PR-URL: #22247Fixes: #21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@jasnell@kjin
doc: clarify http2 docs around class exports
b0aa8f2
PR-URL: nodejs#22247Fixes: nodejs#21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell@kjin
doc: clarify http2 docs around class exports
411acb7
PR-URL: nodejs#22247Fixes: nodejs#21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell@BethGriggs
doc: clarify http2 docs around class exports
3980ca1
Backport-PR-URL: #22850 PR-URL: #22247Fixes: #21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@jasnell@rvagg
doc: clarify http2 docs around class exports
882c2c0
PR-URL: nodejs/node#22247Fixes: nodejs/node#21434 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@trivikrtrivikrtrivikr approved these changes

@mcollinamcollinaAwaiting requested review from mcollina

+2 more reviewers

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

@gdamsgdamsgdams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell@nodejs-github-bot@gdams@addaleax@lpinca@cjihrig@vsemozhetbyt@trivikr