http2: avoid race condition in OnHeaderCallback#22256
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
MemberAuthor
jasnell commented Aug 10, 2018
addaleax approved these changes Aug 10, 2018
jasnell added the author ready 
trivikr approved these changes Aug 12, 2018
gdams approved these changes Aug 13, 2018
Member
gdams commented Aug 13, 2018
landed in: ac92a42 |
gdams pushed a commit that referenced this pull request Aug 13, 2018
Fixes: #21416 PR-URL: #22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
Fixes: #21416 PR-URL: #22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
This was referenced Aug 16, 2018
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
Fixes: nodejs#21416 PR-URL: nodejs#22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
Fixes: nodejs#21416 PR-URL: nodejs#22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
Fixes: #21416 Backport-PR-URL: #22850 PR-URL: #22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
Merged
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Fixes: nodejs/node#21416 PR-URL: nodejs/node#22256 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than abort, close stream when stream does not exist in OnHeaderCallback
Fixes: #21416
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes