doc: discuss special protocol handling#22261
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added doc 
nodejs-github-bot added doc jasnell added the author ready 
MemberAuthor
jasnell commented Aug 11, 2018
Please 👍 to fast-track |
Trott approved these changes Aug 11, 2018
doc/api/url.md Outdated
| ##### Special Schemes | ||
| The WHATWG URL Standard considers a handful of URL protocol schemes to be | ||
| "special" in terms of how those are parsed and serialized. When a URL is |
Member
There was a problem hiding this comment.
- Italics instead of quotes around
special. those->they
doc/api/url.md Outdated
| ``` | ||
| However, changing from `http` to a hypothetical `fish` protocol does not | ||
| because the new protocol is not considered "special". |
doc/api/url.md Outdated
| ##### Special Schemes | ||
| The WHATWG URL Standard considers a handful of URL protocol schemes to be |
Member
There was a problem hiding this comment.
Linking the text WHATWG URL Standard to the standard itself would be useful here. It's already linked in two other places in the doc, so it's just a matter of changing the markdown to [WHATWG URL Standard][].
Member
Trott commented Aug 11, 2018
(Intentionally not approving fast-tracking here. There's enough new material here that it's probably worth not rushing the review process IMO and I'm unaware of any reason to rush landing it. I won't block fast-tracking but I'd ask people to consider carefully if this really needs to be fast-tracked.) |
Member
Trott commented Aug 11, 2018
@jasnell You added the |
MemberAuthor
jasnell commented Aug 11, 2018
Feel free to push your suggested edits to the PR. |
Member
Trott commented Aug 11, 2018
👍 Done. |
trivikr approved these changes Aug 11, 2018
vsemozhetbyt approved these changes Aug 11, 2018
lpinca approved these changes Aug 11, 2018
maclover7 approved these changes Aug 11, 2018
jasnell added a commit that referenced this pull request Aug 11, 2018
Fixes: #13523 PR-URL: #22261 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MemberAuthor
jasnell commented Aug 11, 2018
Landed in 58cf409 (fast tracked with approval) |
targos pushed a commit that referenced this pull request Aug 12, 2018
Fixes: #13523 PR-URL: #22261 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
bengl added author ready 
Member
bengl commented Aug 13, 2018
^ Accidental tag removal and addition. Sorry! |
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Fixes: nodejs/node#13523 PR-URL: nodejs/node#22261 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13523
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes