doc: list encodings supported by buffer.transcode#22263
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added buffer 
nodejs-github-bot added buffer jasnell added the author ready 
Trott removed the author ready 
trivikr reviewed Aug 11, 2018
| conversion from `fromEnc` to `toEnc` is not permitted. | ||
| Encodings supported by `buffer.transcode()` include: `'ascii'`, `'utf8'`, | ||
| `'utf16le'`, `'ucs2'`, `'latin1'`, and `'binary'`. |
Trott reviewed Aug 11, 2018
doc/api/buffer.md Outdated
| Throws if the `fromEnc` or `toEnc` specify invalid character encodings or if | ||
| conversion from `fromEnc` to `toEnc` is not permitted. | ||
| Encodings supported by `buffer.transcode()` include: `'ascii'`, `'utf8'`, |
Member
There was a problem hiding this comment.
include -> are assuming the list is supposed to be a complete list of supported encodings.
MemberAuthor
There was a problem hiding this comment.
Feel free to make whatever editorial changes you'd like
Member
There was a problem hiding this comment.
Wanted to confirm the list is supposed to be complete before doing it. I'll take that as a "yes, it's a complete list" and make the change now. 👍
Member
Trott commented Aug 11, 2018
@nodejs/documentation Not sure if there's a desired formatting standard for "string values permitted for this argument must be from this small set". I don't think we have one, so I'm fine with this the way it is. Regardless, PTAL. |
Trott approved these changes Aug 11, 2018
Member
Trott commented Aug 11, 2018
@nodejs/buffer |
trivikr approved these changes Aug 11, 2018
vsemozhetbyt approved these changes Aug 11, 2018
Contributor
vsemozhetbyt commented Aug 11, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca approved these changes Aug 11, 2018
cjihrig approved these changes Aug 11, 2018
jasnell added a commit that referenced this pull request Aug 12, 2018
Fixes: #15632 PR-URL: #22263 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
jasnell commented Aug 12, 2018
Landed in a5b3c15 (fast tracked with approval) |
targos pushed a commit that referenced this pull request Aug 12, 2018
Fixes: #15632 PR-URL: #22263 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Fixes: nodejs/node#15632 PR-URL: nodejs/node#22263 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15632
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes