lib: Remove unused param for filterInternalStackFrames#22267
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway.
cjihrig approved these changes Aug 11, 2018
maclover7 approved these changes Aug 12, 2018
Contributor
maclover7 commented Aug 12, 2018
Member
trivikr commented Aug 12, 2018
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16376/ |
trivikr approved these changes Aug 12, 2018
maclover7 added the author ready 
BridgeAR approved these changes Aug 13, 2018
jasnell approved these changes Aug 13, 2018
Contributor
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16438/ (edit: ✔️) |
Contributor
maclover7 commented Aug 14, 2018
Landed in 8018146 (made a slight adjustment to commit message so it would pass core-validate-commit) |
maclover7 pushed a commit that referenced this pull request Aug 14, 2018
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: #22267 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
ghost deleted the Author
ghost commented Aug 15, 2018
Thanks! |
rvagg pushed a commit that referenced this pull request Aug 15, 2018
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: #22267 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: nodejs/node#22267 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually we don't refer the
errordirectly infilterInternalStackFrames, so just remove it anyway.make -j4 test(UNIX), orvcbuild test(Windows) passes