docs: bump icu version to avoid confusion#22313
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
icu has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion.
nodejs-github-bot added doc 
vsemozhetbyt approved these changes Aug 14, 2018
Contributor
vsemozhetbyt commented Aug 14, 2018
Contributor
vsemozhetbyt commented Aug 14, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt added the author ready 
benjamingr approved these changes Aug 14, 2018
gdams approved these changes Aug 14, 2018
gdams approved these changes Aug 14, 2018
trivikr approved these changes Aug 14, 2018
jasnell approved these changes Aug 14, 2018
vsemozhetbyt added the fast-track Contributor
vsemozhetbyt commented Aug 14, 2018
Landed in 85f7ae4 |
vsemozhetbyt pushed a commit that referenced this pull request Aug 14, 2018
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: #22313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: #22313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: nodejs/node#22313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist