Skip to content

Conversation

@cjihrig
Copy link
Contributor

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 17, 2018
@danielgindi
Copy link

I think this also closes nodejs/abi-stable-node#318

Copy link
Member

@BridgeARBridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jasnell
Copy link
Member

@cjihrig ... any way to list the notable changes in the PR or commit message?

@cjihrig
Copy link
ContributorAuthor

cjihrig commented Aug 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16586/

There are only, what appear to be, infrastructure related issues on pi1-docker. Resume build: https://ci.nodejs.org/job/node-test-pull-request/16590/

UPDATE: All green CI: https://ci.nodejs.org/job/node-test-pull-request/16594/

Notable changes: - Restores compatibility with the old IPC protocol. - Adds uv_open_osfhandle(). - Adds uv_os_{get,set}priority(). PR-URL: nodejs#22365Fixes: nodejs#21671Fixes: nodejs#15433 Refs: nodejs#21675 Refs: nodejs/node-addon-api#304 Refs: nodejs/abi-stable-node#318 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@cjihrigcjihrig merged commit 4e7d829 into nodejs:masterAug 20, 2018
@cjihrigcjihrig deleted the libuv branch August 20, 2018 12:43
@danielgindi
Copy link

Sorry guys, but I have to do this:

Yeahhhhhhh!

targos pushed a commit that referenced this pull request Aug 21, 2018
Notable changes: - Restores compatibility with the old IPC protocol. - Adds uv_open_osfhandle(). - Adds uv_os_{get,set}priority(). PR-URL: #22365Fixes: #21671Fixes: #15433 Refs: #21675 Refs: nodejs/node-addon-api#304 Refs: nodejs/abi-stable-node#318 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
Notable changes: - Restores compatibility with the old IPC protocol. - Adds uv_open_osfhandle(). - Adds uv_os_{get,set}priority(). PR-URL: #22365Fixes: #21671Fixes: #15433 Refs: #21675 Refs: nodejs/node-addon-api#304 Refs: nodejs/abi-stable-node#318 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@targostargos mentioned this pull request Sep 5, 2018
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 5, 2018
Notable changes: - Restores compatibility with the old IPC protocol. - Adds uv_open_osfhandle(). - Adds uv_os_{get,set}priority(). PR-URL: nodejs#22365Fixes: nodejs#21671Fixes: nodejs#15433 Refs: nodejs#21675 Refs: nodejs/node-addon-api#304 Refs: nodejs/abi-stable-node#318 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2018
Notable changes: - Restores compatibility with the old IPC protocol. - Adds uv_open_osfhandle(). - Adds uv_os_{get,set}priority(). Backport-PR-URL: #24103 PR-URL: #22365Fixes: #21671Fixes: #15433 Refs: #21675 Refs: nodejs/node-addon-api#304 Refs: nodejs/abi-stable-node#318 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Nov 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libuvIssues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig@nodejs-github-bot@danielgindi@jasnell@addaleax@BridgeAR