test: move test-timers-throw-reschedule to sequential#22379
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Aug 17, 2018
ContributorAuthor
MylesBorins commented Aug 17, 2018
sigh... it seems like linuxone has decided to consistently fail on this test now, even with moving it to sequential @apapirovski can you provide any insight into how we might be able to fix this? |
This also sets the test as flaky Refs: nodejs#21188
MylesBorinsforce-pushed the mv-test-timers-throw-reschedule branch from ee2fcc3 to 19d91faCompareContributorAuthor
MylesBorins commented Aug 17, 2018
So the first run of this test failed on linuxone, the full CI run didn't. /cc @nodejs/timers Setting the test to flaky in this PR so it doesn't block the release |
joyeecheung approved these changes Aug 17, 2018
Member
joyeecheung commented Aug 17, 2018
Oddly |
Member
|
ContributorAuthor
MylesBorins commented Aug 17, 2018
@joyeecheung |
ContributorAuthor
MylesBorins commented Aug 17, 2018
landed in 01e2eba |
MylesBorins added a commit that referenced this pull request Aug 17, 2018
This also sets the test as flaky PR-URL: #22379 Refs: #21188 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #21188