Skip to content

[v8.x backport] doc,tools: formalize, unify, codify default values#22388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

[v8.x backport] doc,tools: formalize, unify, codify default values #22388

vsemozhetbyt wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbytvsemozhetbyt commented Aug 18, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Backport of #19737

@vsemozhetbyt
doc,tools: formalize, unify, codify default values
3fb9344
PR-URL: #19737 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 18, 2018

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/586/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v8.x labels Aug 18, 2018
@vsemozhetbytvsemozhetbyt mentioned this pull request Aug 18, 2018
Closed
3 tasks
@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2018
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@vsemozhetbyt@MylesBorins
doc,tools: formalize, unify, codify default values
50316e2
Backport-PR-URL: #22388 PR-URL: #19737 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 6, 2018

landed in 50316e2

@vsemozhetbytvsemozhetbyt deleted the backport-19737-to-v8.x branch September 6, 2018 17:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt@nodejs-github-bot@MylesBorins@jasnell