deps: import [email protected]#22488
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in nodejs#22405.
nodejs-github-bot added the lib / src 
Contributor
refack commented Aug 23, 2018
/CC @TimothyGu |
Member
TimothyGu left a comment
TimothyGu left a comment There was a problem hiding this comment.
Thanks! I admittedly haven't been too diligent on upgrading Acorn… Would you mind regenerating the LICENSE.md file by running tools/license-builder.sh?
update produced by tools/license-builder.sh
jdalton suggested changes Aug 23, 2018
Member
jdalton left a comment
jdalton left a comment There was a problem hiding this comment.
Holding to see if acorn can bump changes in their master so that we can upgrade to the more recent latest and greatest. (if not possible in a few days I'll release the hold)
TimothyGu approved these changes Aug 24, 2018
MemberAuthor
rubys commented Aug 24, 2018
@jdalton"Latest commit bba80ab 17 days ago". Are you pursuing a release or there something I should be doing to make this happen? |
Member
@rubys Just a release. Nothing you need to do (beside bump the acorn dep in the PR when appropriate). Their last release was mid June so if they are able to bump then we'll get more fresh bits is all. |
MemberAuthor
rubys commented Aug 24, 2018
@jdaldon, let me rephrase the question. Are you aware of the acorn team actively preparing a release, or has somebody asked them to produce a release, or are we merely delaying on the off chance that a release coincidentally happens in the next few days? |
Member
Yes, I've inquired about a release. |
MemberAuthor
rubys commented Aug 24, 2018
@jdalton done. Thanks! |
jdalton approved these changes Aug 24, 2018
Contributor
refack commented Aug 25, 2018
bengl approved these changes Aug 25, 2018
MemberAuthor
rubys commented Aug 26, 2018
|
rubys added a commit to rubys/node that referenced this pull request Aug 26, 2018
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in nodejs#22405. PR-URL: nodejs#22488 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MemberAuthor
rubys commented Aug 26, 2018
landed: 49bfc37 |
addaleax pushed a commit that referenced this pull request Aug 27, 2018
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in #22405. PR-URL: #22488 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in #22405. PR-URL: #22488 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
Imported from the tarball published on npm (https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz). Update to emcaScript version 10 in order to get support for binding-less catch statements. Also needed to parse node.js lib API in #22405. PR-URL: #22488 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz).
Update to emcaScript version 10 in order to get support for
binding-less catch statements.
Also needed to parse node.js lib API in #22405.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes