src,deps: wrap library name with TEXT()

[zcbenz]

On Windows when compiling with unicode support, "LoadLibrary" will become "LoadLibraryW" and feeding it with an ANSCII string will cause crash in runtime.

Using TEXT() macro can make the code work no matter whether the unicode support is on.

[bnoordhuis]

/cc @piscisaureus

[piscisaureus]

-1
Just use the A or W version explicitly

[zcbenz]

@piscisaureus Will you accept the commit if I change it to use LoadLibraryA?

And FYI, in V8 and OpenSSL they chose to use TEXT() macro instead of A or W version of API, I'm not quite sure about the reason but using TEXT() seems more consistent:
https://github.com/iojs/io.js/search?utf8=✓&q=LoadLibrary

[piscisaureus]

@piscisaureus Will you accept the commit if I change it to use LoadLibraryA?

I'll accept it if you change it to use LoadLibraryW to make it look like this:

hnd_advapi32=LoadLibraryW(L"advapi32.dll");

The reason is that LoadLibraryA just converts the name from the "active ansi character set" to utf16 and then calls LoadLibraryW internally. The TEXT() macro is a relic from times where people were targeting Windows NT (with unicode support) and 95/98 (no unicode support) at the same time.

[zcbenz]

Sounds quite reasonable to me, I have updated the patch to use LoadLibraryW.

[piscisaureus]

Thanks! Landed in 604b876.

[piscisaureus]

@zcbenz BTW you may want to upstream the patch to c-ares too. Chances are that your change gets reverted when someone upgrades c-ares.

[zcbenz]

I have created c-ares/c-ares#25 for the upstream c-ares.

[MylesBorins]

This landed upstream in cares... although I'm not sure we are backporting changes to LTS. Should this be backported?

[jasnell]

Likely safe. SGTM /cc @nodejs/lts

[rvagg]

@thealphanerd probably not needed, check the diff against v4. This one's a floating patch that kept coming on top of c-ares changes. git log | grep 'src,deps: replace LoadLibrary by LoadLibraryW' (I got confused by this stage while backporting as well).