crypto: fix public key encryption internals#22780
Closed
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect.
nodejs-github-bot added c++ 
BridgeAR approved these changes Sep 10, 2018
lpinca approved these changes Sep 10, 2018
cjihrig approved these changes Sep 10, 2018
jasnell approved these changes Sep 10, 2018
MemberAuthor
tniessen commented Sep 12, 2018
addaleax approved these changes Sep 12, 2018
addaleax added the author ready MemberAuthor
CI was stopped, rebuilding everything... https://ci.nodejs.org/job/node-test-pull-request/17142/ |
MemberAuthor
tniessen commented Sep 12, 2018
CI was green, not sure why GH is not updating accordingly. Landed in 711445b. |
tniessen removed the author ready tniessen added a commit that referenced this pull request Sep 12, 2018
Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect. PR-URL: #22780 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 14, 2018
Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect. PR-URL: #22780 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 19, 2018
Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect. PR-URL: #22780 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2018
Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect. PR-URL: #22780 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have been updated in 6adf3ec. Coincidentally, the old version works as well since the
paddingparameter is nevernull, but it is semantically incorrect.cc @nodejs/crypto
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes