test: fix messages and use return to skip tests#2290
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a followup of nodejs#2109. The tests which didn't make it in nodejs#2109, are included in this patch. The skip messages are supposed to follow the format 1..0 # Skipped: [Actual reason why the test is skipped] and the tests should be skipped with the return statement.
test/parallel/test-dh-padding.js Outdated
Contributor
There was a problem hiding this comment.
Can we make sure the messages are consistent? :D
Contributor
Fishrock123 commented Aug 2, 2015
LGTM if the messages are consistent. |
Member
jbergstroem commented Aug 2, 2015
LGTM |
ContributorAuthor
thefourtheye commented Aug 3, 2015
CI Run: node-test-commit/80 |
thefourtheye added a commit that referenced this pull request Aug 3, 2015
This is a followup of #2109. The tests which didn't make it in #2109, are included in this patch. The skip messages are supposed to follow the format 1..0 # Skipped: [Actual reason why the test is skipped] and the tests should be skipped with the return statement. PR-URL: #2290 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
ContributorAuthor
thefourtheye commented Aug 3, 2015
Thanks guys, landed at 80a1cf7. Since the linter job failed, I ran locally and it didn't raise any concerns. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #2109.
The tests which didn't make it in #2109, are included in this patch.
The skip messages are supposed to follow the format
and the tests should be skipped with the return statement.
cc @bnoordhuis@jbergstroem