Skip to content

doc: add missing metadata#22949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 3 commits into from
Closed

doc: add missing metadata #22949

tniessen wants to merge 3 commits into from

Conversation

@tniessen
Copy link
Member

@tniessentniessen commented Sep 19, 2018

This adds missing metadata for the semver-minor changes in #14731 and #21875 and improves the metadata added in #21616.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2018

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/942/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 19, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 19, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2018
@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 19, 2018
@tniessen
Copy link
MemberAuthor

tniessen commented Sep 19, 2018

Landed in ed35df7...fadafef.

@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2018
tniessen added a commit that referenced this pull request Sep 19, 2018
@tniessen
doc: add missing metadata for dns.lookup
a02b98b
PR-URL: #22949 Refs: #14731 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tniessen added a commit that referenced this pull request Sep 19, 2018
@tniessen
doc: add missing metadata for recursive mkdir
7715273
PR-URL: #22949 Refs: #21875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tniessen added a commit that referenced this pull request Sep 19, 2018
@tniessen
doc: improve metadata for http.request
fadafef
PR-URL: #22949 Refs: #21616 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@tniessentniessen mentioned this pull request Sep 19, 2018
Closed
4 tasks
@targos
Copy link
Member

targos commented Sep 20, 2018

Depends on #21875. Marking dont-land-on-v10.x for now.

targos pushed a commit that referenced this pull request Sep 25, 2018
@tniessen@targos
doc: add missing metadata for dns.lookup
15c7c57
PR-URL: #22949 Refs: #14731 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 25, 2018
@tniessen@targos
doc: add missing metadata for recursive mkdir
91b4102
PR-URL: #22949 Refs: #21875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 25, 2018
@tniessen@targos
doc: improve metadata for http.request
6b2e2ff
PR-URL: #22949 Refs: #21616 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen@nodejs-github-bot@vsemozhetbyt@targos@jasnell@addaleax@lpinca@cjihrig