doc: improve instruction to purple merge#23007
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
devsnek commented Sep 21, 2018
I think you also need to push to your branch before you push to upstream. Can that be mentioned? |
ContributorAuthor
refack commented Sep 21, 2018
Like in the line above that 😉 |
refack added the meta Member
devsnek commented Sep 21, 2018
@refack i mean the explicit order. if you push to upstream before your branch it closes it but does it red instead of purple. |
ContributorAuthor
refack commented Sep 21, 2018
Gotcha |
gireeshpunathil approved these changes Sep 22, 2018
COLLABORATOR_GUIDE.md Outdated
| red closed status. If you close the PR before GitHub adjusts its status, it will | ||
| show up as a 0 commit PR and the changed file history will be empty. Also if you | ||
| push upstream before you push to your branch, GitHub will close the issue with | ||
| red status so the order of operations important. |
Member
There was a problem hiding this comment.
probably operations important -> operations is important. ?
lundibundi approved these changes Sep 25, 2018
lundibundi added the author ready 
Contributor
danbev commented Sep 26, 2018
Landed in 938b269. |
danbev pushed a commit that referenced this pull request Sep 26, 2018
PR-URL: #23007 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Sep 27, 2018
PR-URL: #23007 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes