Skip to content

src: use RAII cleanup in node_i18n.cc#23021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

src: use RAII cleanup in node_i18n.cc #23021

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Sep 22, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 22, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/976/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. labels Sep 22, 2018
@addaleaxaddaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 22, 2018
@addaleax
Copy link
MemberAuthor

addaleax commented Sep 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17389/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2018
@danbev
Copy link
Contributor

danbev commented Sep 25, 2018

Re-run of failing node-test-commit-linux.

@danbev
Copy link
Contributor

danbev commented Sep 25, 2018

Landed in f004936.

@danbevdanbev closed this Sep 25, 2018
danbev pushed a commit that referenced this pull request Sep 25, 2018
@addaleax@danbev
src: use RAII cleanup in node_i18n.cc
f004936
PR-URL: #23021 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax@targos
src: use RAII cleanup in node_i18n.cc
2f659a3
PR-URL: #23021 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@targostargos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@thefourtheyethefourtheyethefourtheye approved these changes

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to the i18n implementation.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax@nodejs-github-bot@danbev@jasnell@thefourtheye@cjihrig@devsnek@gireeshpunathil@BridgeAR