win,msi: display license notes before installing tools#23044
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joaocgreis added windows 
nodejs-github-bot added install 
MemberAuthor
joaocgreis commented Sep 24, 2018
refack approved these changes Sep 24, 2018
BridgeAR added the author ready MemberAuthor
joaocgreis commented Sep 25, 2018
Resumed CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/17413/ (all green) I will land this tomorrow if there are no objections. |
addaleax removed the author ready 
addaleax approved these changes Sep 25, 2018
addaleax added the author ready 
jasnell approved these changes Sep 25, 2018
joaocgreis added a commit that referenced this pull request Sep 26, 2018
PR-URL: #23044 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
joaocgreis commented Sep 26, 2018
2 tasks
targos pushed a commit that referenced this pull request Sep 27, 2018
PR-URL: #23044 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #23003 (comment)
This adds notes about the licenses of packages installed by Chocolatey to the installation script. This was adapted from the README of https://github.com/Microsoft/windows-dev-box-setup-scripts/ .
Please note that there is no more space in one default console window (80x25). To add more information, either something must be deleted or another screen needs to be created.
cc @refack @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes